product list cart

Community feedback

• 

  P

  Raul Galicia•150

  @raulgaliciabPosted 11 days ago

  Hi Yasir,

  Great solution! These are the points that I could see as a feedback:

  Overall project.

  • Having all the logic in one file may not be very readable and maintainable in the long run. With vanilla JavaScript, you could try using ES Modules.
  • Since you are using data.json, the content.txt file seems to have no purpose in the repository.
  • Don't forget to update the README.md with your insights. One of the points of doing the projects is to be able to show the results proudly. :)

  Checkout Modal:

  • You can still scroll the rest of the content when the modal is open. Try to add these styles to the body when the modal is open: overflow: hidden; height: 100vh;
  • If the content in the modal is too large you can't see it complete. One style that could help with this is overflow-y: auto;

  Images:

  • You are just using the mobile version of the images. For dynamic display according to screen resolution try the <picture> HTML tag.

  Marked as helpful

  0

  ---

  

  Yasir Abbas•1,100

  @yasir-abasPosted 10 days ago

  @raulgaliciab Thank you for your detailed feedback.

  0
• 

  Muhammad Siddiq•1,610

  @MS-80Posted 11 days ago

  good effort try to improve more

  Marked as helpful

  0