Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Component using Grid

hannyโ€ข 170

@hannyfish

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Atif Iqbalโ€ข 3,200

@atif-dev

Posted

Hi hanny, congrats๐ŸŽ‰ on completing the challenge. Better take care about following points.

  • Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. To overcome warning: Page should contain a level-one heading. Create level one heading (<h1></h1>) inside main and hide it visually. Although it will be hidden on UI but will be readable for Screen Readers Technology
  • You need to work for centering the card.
  • Write more in your GitHub project's README file. Like, write about your working flow, findings, new learned things, useful resources, etc.

Hope you will find this Feedback Helpful.

Marked as helpful

0
Abdul Khaliq ๐Ÿš€โ€ข 72,660

@0xabdulkhaliq

Posted

Hello there ๐Ÿ‘‹. Congratulations on successfully completing the challenge! ๐ŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HEADINGS โš ๏ธ:

  • This solution has also generated accessibility error report due to lack of level-one heading <h1>
  • Every site must want at least one h1 element identifying and describing the main content of the page.
  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users).

.

I hope you find this helpful ๐Ÿ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

hannyโ€ข 170

@hannyfish

Posted

@0xAbdulKhalid Hi!! Thank you for always commenting, you're super helpful! I didn't actually know about the h1 accessibility thing, so that's wonderful to know! I'll keep it in mind for the future!! Thank you~

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord