Product Component using Grid

Community feedback

• 

  Atif Iqbal•3,200

  @atif-devPosted over 1 year ago

  Hi hanny, congrats🎉 on completing the challenge. Better take care about following points.

  • Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. To overcome warning: Page should contain a level-one heading. Create level one heading (<h1></h1>) inside main and hide it visually. Although it will be hidden on UI but will be readable for Screen Readers Technology
  • You need to work for centering the card.
  • Write more in your GitHub project's README file. Like, write about your working flow, findings, new learned things, useful resources, etc.

  Hope you will find this Feedback Helpful.

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  ---

  • This solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users).

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  hanny•170

  @hannyfishPosted over 1 year ago

  @0xAbdulKhalid Hi!! Thank you for always commenting, you're super helpful! I didn't actually know about the h1 accessibility thing, so that's wonderful to know! I'll keep it in mind for the future!! Thank you~

  0