Skip to content
Submitted about 2 years ago

Product Card w/ custom vars Flexbox Mobile First and Media Queries

cesar hernan ruscica•320
@hernanruscica
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I really like your comments! What do you think about the media queries? it can be more simple? I found a little tricky to make the image equal to the disegn mobile and desktop, but the object-fit and object-position helps me a lot! I split the product card in two, the image container and the text container. That way I can change the flebox atributte flex-direction from "column" to "row". I used bem style names, customs variables and mobile first aproach.

Community feedback

  • Jefferson V. F.•330
    @JorggyhPosted about 2 years ago

    Well done!

    You used only the desktop image?

    You can use two different images, one for mobile and one for desktop, and that's the idea, you can do it with the picture tag, something like this:

    <picture>
     <source media='(max-width: 799px)' srcset='images/image-product-mobile.jpg' type='image/jpg'>
     <img alt=' ' images/image-product-desktop.jpg'>
</picture>

    Or adding the images as background in the css, in mine I did the following, the mobile version:

    #img {
   background: no-repeat center center/cover url("../img/image-product-mobile.jpg");
   height: 24rem;
   border-radius: 0.8rem 0.8rem 0 0;
}

    and the desktop version, inside the media query:

       #img {
     background: no-repeat center center/cover url("../img/image-product-desktop.jpg");
     width: 30rem;
     height: 100%;
     border-radius: 0.8rem 0 0 0.8rem;
   }
    1
    cesar hernan ruscica•320
    @hernanruscicaPosted about 2 years ago

    @Jorggyh thanks for your comment. At first i try to make it with the background option that you mentioned, but later i think that use just one image is a better challenge. I really apreciate this solution with the source media, that I did not know. Thanks for your time !

    0
  • Adriano•38,270
    @AdrianoEscarabotePosted about 2 years ago

    Hi cesar hernan ruscica, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

    The rest is great!!

    Hope it helps...👍

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord