Product Card View

Community feedback

• 

  Rajaul Islam Ratul•1,250

  @ratul0407Posted about 1 year ago

  @abie237 congrats on completing this challenge🎉🎉

  You've done a pretty good job indeed but I think there are some things that you should consider changing

  • Don't set height and width explicitly like you've set in your container instead you can set something like a max-width:37.5rem //600px or anything you feel better goes with the design. By doing this you are depending on your content of the container because the height and width will be set according to the children's and you can space things using margin and padding as you would like. This will help you to deal with the responsiveness of the page.

  I hope it was helpful for you👍👍

  Happy coding my friend🙂🙂

  Marked as helpful

  0

  ---

  

  Abiel Bright•260

  @abie237Posted about 1 year ago

  @ratul0407 thank you . I'm editing it as soon as possible and also applying it to my new projects.👍

  0

  

  Rajaul Islam Ratul•1,250

  @ratul0407Posted about 1 year ago

  @abie237 best of luck for your future projects👍

  1