Product Card using Tailwind

Community feedback

• 

  Izzat Razab•70

  @izzatrazabPosted over 1 year ago

  Hi regarding the node_modules, you can do the following

  1. Add "node_modules" in .gitignore file.
  2. Delete node_modules file
  3. Commit changes (to remove node_modules file in repo)
  4. Run "npm i" again in your workspace (to reinstall all dependecies)

  Next time you commit, it will ignore node_modules file

  Marked as helpful

  1

  ---

  

  Kuzitaa•130

  @KuzitaaPosted over 1 year ago

  @izzatrazab I was looking into the gitignore. Thanks for your help!

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • The h-[100vh] utility class is used to define height: 100vh, But we want to use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  • So we want to use min-h-screen utility class to define min-height: 100vh

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Kuzitaa•130

  @KuzitaaPosted over 1 year ago

  @0xAbdulKhalid I had never heard of that. I'll write it down for the next one. Thank you very much for the comment!

  0