Product card using React & Tailwindcss

Community feedback

• 

  Bishal Singh Deo🎮•1,440

  @Bishalsnghd07Posted 9 months ago

  Hi, @alanjheffernan👋

  You said very well👏 and one more line I wanna add into it "practice makes man Superman" believe it. Practice makes you everything what you want. And in this project your hard work showing of. And always set in your mind that tailwind CSS always use utility first approach and you deliver it and I will give just small recommendation, divide your code into smaller chunks to maintain code structure and code scalability

  I'll just congratulate you to complete this challenge🎉 and want to see amazing projects ahead from you💓

  Happy Coding❤️

  Marked as helpful

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 9 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have an suggestion regarding your code that I believe will be of great interest to you.

  ---

  PiCTURE TAG 📸:

  • Looks like you're currently using custom function named getImageUrl for swapping different version of image.

  ---

  const getImageUrl = () => {
      return windowWidth < 768 ? productMobileImage : productDesktopImage;
    };
  

  ---

  So let me introduce the picture element. It is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.

  • Example:

  <picture>
    <source media="(max-width: 768px)" srcset="small-image.jpg">
    <source media="(min-width: 769px)" srcset="large-image.jpg">
    <img src="fallback-image.jpg" alt="Example image">
  </picture>
  

  ---

  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.

  ---

  • Using this approach allows you to provide different images for different screen sizes without relying on custom functions, and it also helps to improve page load times by reducing the size of the images that are served to the user

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  P

  Alan Heffernan•215

  @alanjheffernanPosted 9 months ago

  Hey @0xabdulkhalid ,

  This is a great suggestion. I didn't even know the <picture> tag existed. This is much tidier.

  I will be using this from now on.

  Thanks for the advice :)

  1

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 9 months ago

  You're welcome, @alanjheffernan! I'm pleased my feedback was helpful to you!

  0