Product Card Solution

Community feedback

• 

  Alex Garcia 🦝 Garcialexco•440

  @garcialexcoPosted almost 2 years ago

  Hello! Great job completing the challenge! 🔥

  There's a couple parts of your code that I might be able to help with:

  • It's best to link fonts in the HTML file, and then assign in CSS wherever necessary. This makes the page load a bit faster!

  • Centering things are super difficult , here's a tip to center an element in the middle of the page:

      position: absolute;
      top: 50%;
      left: 50%;
      transform: translate(-50%, -50%);
  

  • Be sparing in your use of div, here's a hand article about semantic HTML in regards to div usage: https://dev.to/kenbellows/stop-using-so-many-divs-an-intro-to-semantic-html-3i9i

  Hope this helps, and keep up the great work! 👍 Happy Coding!

  Marked as helpful

  0

  ---

  

  John Evans•20

  @JohnPalmTreePosted almost 2 years ago

  @garcialexco Thank you for the feedback! I found the article really helpful & I'm going to integrate your help into my work going forward.

  0