Product Card | Minimal, HTML, CSS

Community feedback

• 

  Francisco Carrillo•5,540

  @frank-itachiPosted almost 2 years ago

  Hello there 👋. Congratulation for completing the challenge👍!

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.
  • If your code has different sections that have a specific purpose like a navigation, article, sections or footer, it’s a good practice to enclose those parts with HTML5 landmarks. For example, you could use a <footer> tag to wrap the <div class=”attribution”> section.
  • Since the mobile design has a different image, you can use the <picture> tag that allows you to interchange the images depending of the viewport size. Red more about this awesome tag here.
  • The heading order is important in the html structure so try to always start your headings with an <h1> tag and then you can decrease by one if you need to use more heading in your html code.
  • Make sure that the <img> elements in your HTML code has an alternate (descriptive text) short text. The reason for this is that screen readers can’t translate images into text. So to fix this you can do the following <img src=”…” alt=”short text” >

  I hope you find it useful! 😄 Above all, you did a good job!

  Happy <coding /> 😎!

  Marked as helpful

  2

  ---

  

  P

  Vivek•150

  @tweetandcodePosted almost 2 years ago

  @frank-itachi thanks for pointing out the picture tag, will look into it and deploy it a bit later, this is something I didn't know.

  0