@CaplexW
Posted
Hello Abhi! You did a great job! Here's some minor adjestments I wanted to advice, that might improve your work in the future:
- Try to avoid setting
width
andheight
inpx
. The reason is - it is an absolute units and it will make maintaining responsivness of you site much harder. Instead you can use responive units likeem
andrem
. You can dive deeper in the topic in this article. - Try to avoid setting specific
height
to content elements at all costs. Setting any specificheight
(inpx
orrem
) will mostly likely kill the responsivnes of you site. You can pickup some good practices of working withheight
in this Web Dev Simplified video. - Don't leave body as a row. If you have to put
display: flex
on abody
element, make itflex-direction: column
. It won't matter in this project, but in more complexed sites it will save you a lot of enegry. - Consider using
svh
ordvh
for document height. It's not bad at all to usevh
, but you might consider usingsvh
instead cause it's taking in account UI element on the screen, slightly improving mobile experience. You can dive deeper by watching this video of Kevin Powell. - You can use
letter-spacing
. It's small one. In this challenge, word 'PERFUME' is slightly modified with space between letters. You can achive the same result with css by usingletter-spacing
property.
And don't be ashamed to use ChatGPT in you work, it's a greate tool of knowledge as long as you use it to ask questions and understand what you've missed instead of just copy-pasting suggested solution without understanding how it work. Good luck with a future work!
Marked as helpful
@abhi-zero
Posted
@CaplexW Thanks, bro, for giving me advice and providing the link. From now on, I’m going to do as you said.
@CaplexW
Posted
@abhi-zero I'm really flattered! But don't do as I said (afterall I'm just a student like you) - do as you understand. Just use my words to look where you can expend your understending. ;)
Marked as helpful