Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Card

@TahaKhursheed105

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Luigi Barandaβ€’ 340

@Lbaranda26

Posted

Great start!

I suggest you to download the Figma or Sketch design to get the correct sizes of the elements.

Keep up the good work.

Marked as helpful

0
Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have a suggestion regarding your code that I believe will be of great interest to you.

HTML 🏷️:

  • This solution contains a minor semantic mistakes which may cause accessibility issues
  • The <h2>PERFUME</h2>, must want to be changed to normal case like Perfume
  • It’s not great for screen readers, because uppercase text will be read out as individual letters (like abbreviations). So CSS is read as C.S.S. Just as PERFUME would be read as P.E.R.F.U.M.E, not as the word Perfume
  • You can read more about that in this article on Medium
  • Don't worry we can use text-transform: uppercase to transform the letter and letter-spacing: 1rem for the text Perfume
  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

I gladly welcome you to the Frontend Mentor Community, Happy Coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord