Product Card

Community feedback

• 

  Luigi Baranda•340

  @Lbaranda26Posted 6 months ago

  Great start!

  I suggest you to download the Figma or Sketch design to get the correct sizes of the elements.

  Keep up the good work.

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted 6 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution contains a minor semantic mistakes which may cause accessibility issues

  ---

  • The <h2>PERFUME</h2>, must want to be changed to normal case like Perfume

  ---

  • It’s not great for screen readers, because uppercase text will be read out as individual letters (like abbreviations). So CSS is read as C.S.S. Just as PERFUME would be read as P.E.R.F.U.M.E, not as the word Perfume

  ---

  • You can read more about that in this article on Medium

  ---

  • Don't worry we can use text-transform: uppercase to transform the letter and letter-spacing: 1rem for the text Perfume

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  I gladly welcome you to the Frontend Mentor Community, Happy Coding!

  0