Product Card | Frontend Mentor

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • The element <div class="button card__button"> should be a button and not a div, any element that has a hover state and a pointer cursor is an interactive element (buttons, links, etc).

  • You can use the <picture> tag when you have different versions of the same image 🖼. Using the <picture> tag will help you to load the correct image for the user's device. You can read more about this here 📘.

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

    If you want to learn more about the alt attribute, you can read this article. 📘.

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  0

  ---

  

  ,,,,,,,,,,,•70

  @ReaGetPosted almost 2 years ago

  @MelvinAguilar Thanks! This is really helpful information.

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <h3> with <h1> to fix the accessibility issue.

  To center .card on the page using flexbox, replace the height in .container with min-height: 100vh.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  ,,,,,,,,,,,•70

  @ReaGetPosted almost 2 years ago

  @Hassiai thank you for your feedback! I'm going to read more about relative units :)

  0