Product card design using HTML and CSS.

Community feedback

• 

  Mykyta Kavetskyi•240

  @OniOddPosted about 1 year ago

  Hi! :)

  Your images are not displayed because you entered the wrong path to them. You have specified the path to the images/ folder, but the images are right next to the index.html file.

  Wrong path: images/image-product-desktop.jpg

  Right path: ./image-product-desktop.jpg

  A font family is not displayed because it is overwritten by another font family. You have placed text in the pre tag, which has its own font, monospace. Therefore, you should apply the font-family property directly to the pre tag to overwrite its default font. Also, those fonts that were connected externally (google fonts), their name must be in quotes:

  font-family: "Montserrat", sans-serif;

  font-family: "Fraunces", serif;

  To center an image with text, you need the Flexbox. Here's a mini-game that will help you learn how to use this property: https://flexboxfroggy.com/

  Good luck! :)

  Marked as helpful

  1

  ---

  

  Mazen Mohamed•90

  @lowkey-mazenPosted about 1 year ago

  Hello, @OniOdd. Thank you so much for the tips I will make sure to implement them in my upcoming projects :)

  0
• 

  HipsterShaggy•170

  @Jakub-GryczkaPosted about 1 year ago

  Hi!

  1.As someone above me mentioned about the images. You're pointing to the images/ folder where all your images would be, but you didn't uploaded this folder into Github. That's why the images aren't showing. You should do path either image-product-desktop.jpg or upload the images folder to github and move all of the assets into that folder. This should work.

  2.The font-family isn't working for brand name because the text is in <pre> tag, which has different font and isn't inheriting it by default. Just set the font-family: inherit on the <pre> and it would work :D.

  3.To place the image next to the text I would recommend using Flexbox. Use it on the parent element (in your case on the-button). Moreover you could perfectly center those items. It would be like that:

  .the-button {
     display: flex;
     justify-content: center;
     align-items: center;
     gap: 1em;
  }
  

  • display: flex sets the display to flex, allowing you to use flexbox on this item.
  • justify-content allows you to justify the items along main axis which is x-axis (from left to right in this case)
  • align-items allows you to align items along cross axis, which is y-axis (from top to bottom again, in that case)
  • gap as the name shows, creates a gap between flex-items. You could also use it on grid elements. You should learn flexbox, so those properties will be clear, I just wrote some simplification for you to understand why those things happens.

  4.After opening the website, the main part of website isn't in the center. It's aligned with hard-coded margin-top and margin-left. Again, better solution for this is flexbox. Add those lines to make it perfectly centered:

  body {
    display: flex;
    justify-content: center;
    align-items: center;
    min-height: 95vh;
  }
  

  min-height is a property for minimum height of an element. In this case, 95vh and the vh stands for viewport height, so of the screen height.

  Also, there's some HTML semantics lacks, I recommend Kevin Powell's latest video on YouTube: https://www.youtube.com/watch?v=K_EVuLegRZ0&t=875s

  Hope it helps!

  Marked as helpful

  0

  ---

  

  Mazen Mohamed•90

  @lowkey-mazenPosted about 1 year ago

  Hi, @Jakub-Gryczka. I can't express how helpful this was I truly appreciate it. I will make sure to check out the video you recommended and thank you so much :)

  0