This project is a really good practice for beginners. I learned using flexbox and responsive design. However, I am not for sure my css code is clean or not. Welcome feedbacks!
@JimTK16
Posted
Nicely done Eric.
I'm a beginner too, so take my words with a grain of salt :). I think in general we should avoid setting a fixed width for image or element. Instead, for the container you could set a max-width, and for the image you could set width: 100% so it take the full width of its parent.
Jim
Marked as helpful
@Call4julius
Posted
Nice code.
I think you are not relying on inheritance enough, hence, it makes you repeat yourself.
Also, why do you need TWO media queries?
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
