Product Card Component - BEM, Flexbox - #challenge_02

Community feedback

• 

  Luka Glonti•3,440

  @lack21Posted over 1 year ago

  Great job 👍, but I have some recommendations!

  • Remove height: 90vh from the body and add min-height: 100vh, like this layout will be responsive on desktop and mobile.
  • Add following styles to the .btn

    {
      display: flex;
      justify-content: center;
      align-items: center;
      gap: .5rem;
    }
  

  It's going to make button look better!

  Marked as helpful

  1

  ---

  

  rishi•60

  @rishi-jsdevPosted over 1 year ago

  @lack21

  Thanks for the tip ! 🙏

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  PiCTURE TAG 📸:

  • Looks like you're currently using media queries for swapping different version of image, So let me introduce the picture element.

  ---

  • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.

  ---

  • Example:

  <picture>
    <source media="(max-width: 768px)" srcset="small-image.jpg">
    <source media="(min-width: 769px)" srcset="large-image.jpg">
    <img src="fallback-image.jpg" alt="Example image">
  </picture>
  

  ---

  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.

  ---

  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0