Product card component - REK

Community feedback

• 

  Adriano•42,760

  @AdrianoEscarabotePosted 3 months ago

  Hi KABORE, how are you doing? I really loved the outcome of your project, but I have a few suggestions that I think might be helpful:

  Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  The rest is excellent.

  I hope you find it useful. 👍

  Marked as helpful

  0

  ---

  

  KABORE•80

  @rayagnewendePosted 3 months ago

  Hi Adriano, I'm very good and you? thanks for your feedback. you're good suggestions. indeed I do not think to use picture tag. I'm going to update my solution in using picture tag. have a nice day.

  1
• 

  Nikhila D•580

  @Nikhila-DNPosted 4 months ago

  Hi @rayagnewende, Your solution for the Product preview card component looks great, but I have a few suggestions that can be helpful:

  I have noticed that the Card image has a full Border Radius, but we need only the left-top and left-bottom for Desktop and mobile, top-left and top-right.

  Solution for this problem:

  border-radius:top-left top-right bottom-right bottom-left;

  The remaining is great.

  I hope you find it useful. 👍

  Marked as helpful

  0

  ---

  

  KABORE•80

  @rayagnewendePosted 4 months ago

  @Nikhila-DN: thank you for the suggestions. I appreciate that.

  1