Product Card

Community feedback

• 

  P

  Lo-Deck•3,500

  @Lo-DeckPosted 4 months ago

  Hi well done for this challenge,

  You need to use more semantic tag to improve your HTML, it's better for screen-reader and SEO.

  Use a div when there is no other choices, you can use section, article...MDN.

  like <div class="container"> to <main class="container">.

  You can use picture tag to display different image depending on the size. Here a link : MDN.

  <picture>
    <source media="(max-width: 799px)" srcset="your path" >
    <source media="(min-width: 800px)" srcset="your path" >
    <img src="your path" alt="your description" >
  </picture>
  

  It's better to use em or rem instead of px. FreeCodeCamp. FreeCodeCamp.

  Last try to do the mobile-version when you do a challenge.

  Hope to be helpful.

  Marked as helpful

  0