Product-Card

Community feedback

• 

  FirstHalcyon•90

  @FirstHalcyonPosted 12 days ago

  Hey, great job, it looks identical on the preview.

  I'd consider adding some more semantic HTML elements (avoid a few divs and spans), but there's nothing functionally wrong with it.

  Weird thing, but the desktop design looks super off on the github pages link. The right container is fine, but the image is only 25% of the container's width. Not sure why it does this, it looks good on the preview, but I'm giving it a mention. Might be a 'me' thing, I don't know. Can't post an image here, unfortunately.

  Mobile looks good, though, keep it up!

  0

  ---

  

  ujwal282•50

  @ujwal282Posted 12 days ago

  @FirstHalcyon Hey, thanks so much for the feedback! I appreciate the suggestion about adding more semantic HTML elements—I'll definitely look into that. And thanks for pointing out the issue with the desktop view on GitHub Pages; I'll see if I can fix that. Really glad to hear the mobile version looks good! 😊

  1