
Design comparison
Community feedback
- @Mathieu-310Posted 21 days ago
Hi!
Great job :)
Here's some suggestions: You have a lot of unused css rules so they can slow down your site load time. It is best to delete all unused properties.
I think "add in card" is not a button but just a link which will navigate people to a payment page so use an
<a></a>
tag instead.Lastly you have to use max-width to manage the width of your product's container because it looks very wide on medium screens. Just use a div element here because it's just for styling purposes so there is no need for article element.
Happy coding!!
Marked as helpful1@SimonMcCafferyPosted 21 days ago@Mathieu-310
Thank you for the suggestions, still working around the idea of semantic HTML so I may have gotten a bit carried away with the article and button.
Appreciate the feedback.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord