Design comparison
SolutionDesign
Community feedback
- @NikitaVologdinPosted about 2 months ago
@pavocados you did a great job! Want to highlight a few things:
- It looks you have higher letter spacing for 'parfume' paragraph then in design, yours is 0.4 rem in design is 0.3125rem. I also suggest to use some meta-tag like strong or em to highlight this information for search engines and screen readers. Also your font-size here looks a bit bigger than it should be 0.875rem against 0.75 rem in design and need to add font-weight: 500.
- Great job with the title and description paragraph. Just want to suggest to add line-height for description paragraph of 1.43rem.
- Nice work with pixel perfection of main price. I noticed sliced difference of font-size for old price here it should be 0.8125rem in my opinion.
- Add-to-cart-button`s border radius slightly bigger than in design, i would suggest to put 0.5rem. Transition delay makes this button look outstanding.
Great job with right side paddings and percentage proportion. Thank you for reading. With respect, Nikita.
Marked as helpful1 - @fakegioPosted about 2 months ago
The page is responsive, the html is well-structured, and even the file system is neat and organized. I would just work on the spacing between elements and letter spacing in the perfume category.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord