Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Card

gozica 50

@gozica

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am proud of using the position absolute property and being able to align everything perfectly.

Community feedback

Adriano 36,730

@AdrianoEscarabote

Posted

Hi gozica, how’s everything? I think your project turned out great! However, I have some feedback that I think might be useful:

Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

See the example below:

<picture>
  <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
  <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
</picture>

The rest is amazing.

I hope this is helpful. 👍

Marked as helpful

0

gozica 50

@gozica

Posted

Hello! Thank you for the feedback. The picture tag is something I will definitely look into.@AdrianoEscarabote

1
Adriano 36,730

@AdrianoEscarabote

Posted

@gozica no problem, keep coding!

0
1lija 80

@1lija

Posted

It does look like the image provided but its not responsive which this whole exercise is about. Not really a major miss but you forgot to add hover on the button. That's a pretty easy fix. Keep up the work!

0

gozica 50

@gozica

Posted

Thank you! Also I cannot see the hover feature because I was unable to open the page. All I can use for reference is the layout provided. @1lija

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord