Design comparison
Solution retrospective
This is my "first time" putting grid & flex to use. Any enlightenment would be great
Community feedback
- @FernandoChurrosPosted almost 2 years ago
Hi @Omrividal 👋, good job completing this challenge! 🎉
I have some suggestions you might consider to improve your code:
-
The
margin
in your .card to center is unnecessary as it is flexbox aligning. -
For lower resolutions, a
margin: 2rem
on the sides just so elements don't stick to the edges would be more visually pleasing. -
HTML itself provides option to choose which image will appear depending on user resolution, have a look at documentation picture .
Above all, the project is done well👏. I hope those tips will help you! 👍
God job, and happy coding! 😁
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord