Skip to content
Submitted 6 months ago

prodcut-card

salahdine•100
@salahdinebocuif
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Finish this project and learning new git command

What challenges did you encounter, and how did you overcome them?

I have problem with image and i overcome the problem withe setting height to the image and container

What specific areas of your project would you like help with?

Anything that needs repair

Community feedback

  • N1Dovud•150
    @N1DovudPosted 6 months ago

    Hi, it seems like your design for desktop perfectly matches that of the solution. But I notices some problems with responsiveness. First of all, I would suggest using a media query when the main content does not fit into the screen. Secondly, you called your css file index.css, which is usually not a convention. Although it is not a mistake, as a rule of thumb it is usually called styles.css. Also, I noticed some tag problems in your html file. Try to use semantic tags whenever possible. It helps screen readers and web crawlers to understand its structure and what it is about. Other than that, use appropriate tags. I notices you used div for paragraphs, headings and used paragraph tag for prices, which is not a good idea. Well again, I am not a pro myself but I tried to help you out. If you need some ideas, you can go over my solution for this project. If you have any specific questions, I am ready to help you out!

    Marked as helpful
    0
    salahdine•100
    @salahdinebocuifPosted 6 months ago

    @N1Dovud thank you

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord