Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Primer ejercicio responsivo - Componente QR

@BrandonJr20

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@lgwarda

Posted

Your solution is well-structured and visually appealing, with a clean layout. It effectively meets the requirements of the QR code challenge. Here’s some specific feedback on key areas:

  • Use of Semantic Elements: The structure could benefit from additional semantic elements. Consider using <header>, <main>, and <footer> tags to enhance the HTML semantics. For example, wrapping the main content in a <main> tag can improve the document's structure and accessibility.
  • Image Alt Text: The alt attribute of the image could be more descriptive. Instead of "QR DE LA PAGINA FRONTEND MENTOR," consider using "QR code linking to Frontend Mentor website" to provide context for screen reader users.
  • Heading Structure: Since you have a heading (<h1>), make sure that it’s the primary heading of the page. If there are multiple sections, consider using <h2> for subsections to maintain a proper heading hierarchy.
  • Contrast: Check the color contrast between the text and background to ensure it meets accessibility standards. Tools like the WebAIM contrast checker can help you with this.
  • Media Queries: Your media query adjusts the card size well for smaller screens. However, consider testing it on a range of devices to ensure it looks good across various screen sizes.
  • Flexibility: You might want to explore using percentage-based widths or flexible units (like vw or vh) to enhance the adaptability of your layout.
  • CSS Organization: The CSS is generally clear and well-organized. For improved readability, consider grouping related styles together and adding comments to explain sections or complex styles.
  • Reusability: To enhance reusability, you could create utility classes for common styles (e.g., margin and padding) instead of applying them directly in specific classes. This could reduce redundancy in your CSS.
  • Design Differences: Ensure the visual design closely matches any provided specifications (if applicable). While the overall design looks good, verify that font sizes, colors, and spacing match the intended design.
  • Testing with Screen Readers: Try testing your page with a screen reader to see how the content is read. This will help identify any areas for improvement in accessibility.
  • Performance: If the image size is large, consider optimizing it for better performance, especially for mobile users.
0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord