@Hassiai
Posted
Replace <div id="card"> with the main tag, <h2> with <h1> and <h3> and <h4> with <h2> to fix the accessibility issue. click here for more on web-accessibility and semantic html
To center #card on the page using flexbox or grid instead of margin, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
USING FLEXBOX:
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
USING GRID:
body{
min-height: 100vh;
display: grid;
place-items: center;
}
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Use the colors that were given in the styleguide.md found in the zip folder you downloaded.
There is no need to give #card an the sections height values rather give the sections the same padding values for the sides. this will prevent the content from overflowing.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful