Pricing page using pure HTML, CSS and Javascript

Community feedback

• 

  Justin Punzalan•535

  @justAdevTVPosted about 4 years ago

  Great work overall 👏

  It's responsive and pretty!

  The only thing that sticks out to me is that you have more than one h1 tag on your page. Your main header, "Our Pricing", should be in an h1 tag and the card titles like "Basic" should be in h2 tags.

  I hope you find this useful, Justin P

  0

  ---

  

  Chiji•470

  @DevcodeCJPosted about 4 years ago

  @justAdevTV Thanks for the comment. I usually find it more productive when I use h1 tags for the largest fonts, not the font in the header. All other fonts then follow based on their size/appearance.

  I’m hoping that’s okay and doesn’t go against any programming standards.

  Thanks!

  0

  

  Justin Punzalan•535

  @justAdevTVPosted about 4 years ago

  @DevcodeCJ I totally understand you from a developer-experience perspective. It is more work to go and styled those tags more.

  However, from an accessibility standpoint, you should be mindful of the tags you use though. Read about it below.

  Best Practices From Firefox: "Avoid skipping heading levels: always start from <h1>, next use <h2> and so on.

  You should only use one <h1> per page. Using more than one will not result in an error, but using only one is seen as a best practice. It makes logical sense — <h1> is the most important heading, and tells you what the purpose of the overall page is."

  Source: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements#Usage_notes

  Let me know your thoughts!

  1

  

  Chiji•470

  @DevcodeCJPosted about 4 years ago

  @justAdevTV Well from that standpoint it makes way more sense. The h1 tag passes on the main message about the page and should be used in the heading of each page. When there are multiple h1s it definitely passes on the wrong message. I totally agree and will make time for the read.

  Thanks!

  0

  

  Justin Punzalan•535

  @justAdevTVPosted about 4 years ago

  @DevcodeCJ Awesome. If you make changes to this project, let me know! I'd like to see it :D

  0