Pricing component with toggle using HTML, CSS & JS

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  You've done an awesome job on this challenge, Alexandra! It's great to see that you've managed to complete the Bonus as well by not adding JavaScript! 🥳

  I'd be interested in hearing why you've got your media queries in a separate file. I'd usually recommend keeping them inside your main styles file.

  Keep up the great work!

  1
• 

  Alexandra Barka•255

  @aLe3ouLaPosted almost 5 years ago

  I used a little Javascript =)

  It helps me in development, no specific reason. I have used to keep my files separate from my SASS 7-1 architecture I guess.

  0

  ---

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  @aLe3ouLa ah yes, I missed the JS at the bottom of the HTML file! Nice work. You're using the general sibling selector (~) in your CSS which is great. One nice extra challenge would be to refactor your HTML code so that the general sibling selector can be used to toggle the display of the prices based on whether or not the input is :checked. This would mean you would actually be able to remove the JS altogether! 🙂

  1
• 

  Alexandra Barka•255

  @aLe3ouLaPosted almost 5 years ago

  Your feedback is welcome!

  0