Design comparison
Solution retrospective
Hello! This is my third challenge solution. Feedback and suggestions are very much welcome. Thank you!
Community feedback
- @pikapikamartPosted over 3 years ago
Hey, great work on this one.
My suggestions would be that
-
Adding a
padding-top
in yourbody
tag so that your component won't be touching the ceiling of the viewport like it is doing right now. Also somepadding-bottom
as well just to keep being consistent if you were to add this one. -
Scrollbar. There seems to appear a scrollbar at the bottom at around point 1050px going down to 770px. This was caused by the card's width since the body cannot occupy it. I think it will be better if set another layout on those breakpoints, or made the card's width responsive when shrinking down the browser. But keep in mind that if you were to set this, at some point, the cards will get too looked squished so you have to made another breakpoint on those.
-
Cursor. It will be awesome if you add like
cursor: pointer
in yourlearn more
buttons. Since they are interactive element, adding it will be really good just to make it more natural.
Other than those, your solution is really good and great job on this one^^
2@sjneriPosted over 3 years ago@pikamart I didn't work much on the responsive, thanks for pointing this out. I'm taking down notes. Appreciated this!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord