Pricing Component With Toggle

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Erik Tangvik! 👋

  Nice work on this challenge! 👍 Your solution looks good and is responsive! 👏

  I suggest,

  • Allowing users to scroll in the desktop layout of the site (currently, vertical scrolling is disabled, meaning some of the content of the page is cut off and unreachable on smaller screens).
  • Using CSS background images to add and position the background SVGs in this challenge, as it'll keep your markup cleaner and is often easier to position.
  • Making the toggle-switch tabbable so that users can access and use the toggle-switch.

  Keep coding (and happy coding, too)! 😁

  And happy holidays! 🎄

  1

  ---

  

  Erik Tangvik•255

  @Etang131Posted almost 4 years ago

  @ApplePieGiraffe I fixed the li lines that were out of place as well.

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  @Etang131

  Just took another look—good work! 👍

  1
• 

  Abhik•4,840

  @abhik-bPosted almost 4 years ago

  Hi Erik, Your solution is absolutely perfect 🔥

  • it is very responsive
  • toggle mode is working absolutely fine
  • just a opinion you can use background-image instead of img tags because those svgs are just for decorations

  Great job on this challenge 👌👌, Keep it up 💯

  1

  ---

  

  Erik Tangvik•255

  @Etang131Posted almost 4 years ago

  @abhik-b Thanks for the advice I cleaned it up a bit more.

  0