Pricing Component with Toggle

Community feedback

• 

  Simon Davis•505

  @SkidragonPosted over 3 years ago

  Hi Ejovi, looks pretty good. :) I would suggest looking into em vs rem for CSS and the dangers of using fixed heights from Kevin Powell from Youtube. Also next time use a mobile first approach for your media queries, these things will save you more time on bigger projects. For the main content section, I would suggest a main element in place of a section element to communicate better that this is your main content.

  0

  ---

  

  Ejovi Okiekpakpo•345

  @ruona88Posted over 3 years ago

  @Skidragon

  Okay friend, thanks.

  0
• 

  Mojtaba Mosavi•3,760

  @MojtabaMosaviPosted over 3 years ago

  @ruona88 good job, looks nice and reponds well. There are a few subtle things that you can improve such as.

  1. For "our pricing" use heading tag instead of <p>.
  2. Use a form tag for the switching functionality instead of a div since its more sementic.

  Happy coding :)

  0

  ---

  

  Ejovi Okiekpakpo•345

  @ruona88Posted over 3 years ago

  @MojtabaMosavi

  Thanks for your comment. Are you saying I should use something like a radio button for the switch ?

  0

  

  Mojtaba Mosavi•3,760

  @MojtabaMosaviPosted over 3 years ago

  @ruona88 Yes(you need two), but you should use a form tag as the container for you input instead of a div.

  Happy coding :)

  0