Pricing component with toggle

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hi, Samuel Palacios! 👋

  Nice to see you complete another challenge! 😀 Great job on this challenge! 👏 Your solution looks good and the toggle-switch works well! 👍

  I only suggest adding some outlines to the toggle-switch and the buttons on the page so that keyboard users can easily tell when those elements are tabbed to. 😉

  Keep coding (and happy coding, too)! 😁

  2

  ---

  

  Samuel Palacios•615

  @samuelpalaciosdevPosted over 3 years ago

  Hey there!

  Thank you for your feedback, keep happy coding too💛

  0
• 

  P

  Dave•5,295

  @dwhensonPosted over 3 years ago

  This is a lovely solution! Great work. One other suggestion is to perhaps try and improve the experience for screenreaders?

  I'm not 100% sure how, but it would be nice if the toggle announced what was being toggled so that people could tell the difference. At the minute I just hear "checked" and "unchecked". I'm going to re-do my solution over the next few days and see if I can get this sorted though!

  But I really like the way you have structured your HTML and CSS on this challenge. I might copy some over to mine when I re-do it!!

  Cheers!

  1

  ---

  

  Samuel Palacios•615

  @samuelpalaciosdevPosted over 3 years ago

  Hey there!

  What a great compliment,I will be waiting for your solution ;). Thank you for your feedback💙

  0

  

  P

  Dave•5,295

  @dwhensonPosted over 3 years ago

  @samuelpalaciosdev I tried to improve things with radio buttons rather than a checkbox. Not altogether successful though. My attempt is here:https://www.frontendmentor.io/solutions/updated-toggle-switch-EkMLoY-Bd

  0