@pikapikamart
Posted
Hey, great work on this one. Layout in desktop is good, as well as the mobile. Transitioning though, at point between 990px - 860px, the layout is being hidden thus creating a horizontal scroll. The functionality also works just fine.
Some suggestions:
- Since, this is like a one component, I wouldn't use
header
tag and instead there will bemain
tag that wraps the whole content. - Always include atleast 1
h1
per page. On this one, it could be the "Our Pricing" text, or you can make a screen reader onlyh1
that describes the content andh2
for the "Our Pricing". Either one could be great. - The "annually" and the "monthly" should be a label for the toggler. So that a user can click either "annually" or "monthly". However, I didn't use it this way since I used radio button for my solution long before. I used radio button because it is a selection of choices, and radio buttons are intended for those.
- The name of the pricing like "basic" along with their respective pricing could be wrap inside their own heading tag like
h2
. This makes it clear for a screen reader user on what is the price of such pricing names. - The informations like these ones "500 GB Storage, 2 Users Allowed, Send up to 3 GB" could be wrapped inside a
li
element, inside of aul
. Since those are list of informations regarding the subscription, aul
is fitted for it.
Other than those, really great work. Also you can drop any question if you have.
Marked as helpful