Design comparison
Solution retrospective
All feedback will be highly appreciated
Community feedback
- Account deleted
Hello @cacti00 😊
Your solution is great✨ and congratulations for successfully completing a newbie challenge🎉
and there is a small suggestion that might be helpful for you
min-height :
You can use min-height instead of height
because height will put your element to a size of 100% of it's container. min-height will put the element to min 100% of the container size.
if we set
min-height: 100vh
then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in spaceand it will helpful when you make responsive solutions
Use List
:
Why Us
section is a list of features so instead of multiple<p> tag
you can useunordered list
You also can take a look of
my solution
Hope that was helpful 😊
Marked as helpful0@cacti00Posted over 1 year agoThanks a lot I’ll work on making my website more responsive @MrSandipSharma
0Account deleted@cacti00
I am glad that was helpful for you😀
0 - @Aimal-125Posted over 1 year ago
In your CSS code, give body element height of 120 or 150vh by using media query with
max-height: 400px;
for screens with small heights so that your web app look good on small screens.0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord