Abdul Khaliq 🚀• 72,660
@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS 🎨:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
margin
orpadding
.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states
- To properly center the component in the page, you should use
Flexbox
orGrid
layout. You can read more about centering in CSS here 📚.
- For this demonstration we use css
Grid
to center the component.
body {
min-height: 100vh;
display: grid;
place-items: center;
}
- Now remove these styles, after removing you can able to see the changes
.container {
margin: 0 auto;
margin-top: 10%;
}
- Now your component has been properly centered
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0
Shwe Win Aung• 80
@niteash
Posted
@0xAbdulKhalid I removed
.container { margin: 0 auto; margin-top: 10%; } and everything is fixed. Thank you for your help. I did not need to use grid css to put centre.
0
Abdul Khaliq 🚀• 72,660
@0xabdulkhaliq
Posted
@niteash Glad you found it helpful ! 🤠
0