Design comparison
Solution retrospective
Any feedback is appreciated. Especially around improvements to my approach to site responsiveness.
Community feedback
- @MasterDev333Posted almost 4 years ago
@Ryan, Great work so far. In my humble opinion, it would be great if you use CSS grid or flex in this challenge. You used display: table, but it's kinda an old hat. Hope it helps. Happy coding :)
0 - @lukebergmannPosted almost 4 years ago
Hey Ryan!
This is looking pretty spot on. The sizing is looking great. Two things that I would suggest would be first, to size the main box a little more rectangular. It is seeming a little squishy the more square the shape. A rectangular shape may give the whole layout a little bit of room to breath. Secondly, I would focus my attention onto the harshness of the box shadow. In the Design version, the shadow drops from the top whereas yours sort of encompasses the entire box. Eliminating the top shadow will have more of an believable and crisp effect!
Honestly, it's looking pretty dope, keep it up!
Happy coding, Luke
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord