Price Component

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  👋Hi David Maillard! My name is Vanza!

  I have some feedback on this solution:

  • For the .list you can use ul and li rather than p and br tags.
  • Try to use rem unit. It's simply because it allows the user to change the font size based on their setting.
  • For the line-height and letter-spacing, I recommend to use em unit since they will adjust base on font-size
  • I see that you use will-change property on .button, which is in my opinion, is too over kill since the purpose of will-change is to optimize and fix existing performance problems. For just changing background-color is not a big problem in terms of performance.

  I have a question for you, are you a professional developer? If yes, then can you explain to me why you need to license this project?

  That's it! Hopefully this is helpful and you can answer my question!

  Happy Coding!

  Marked as helpful

  0

  ---

  

  David Maillard•375

  @DavidMaillardPosted over 3 years ago

  @vanzasetia Hi Vanza, you're absolutely right !

  I have never used rem or em units so I am not familiar to it. I will test them on this project to train myself.

  For the will-change, it is a habit that I took with each transition. In which cases do you recommend me to use it ?

  For the licence, this is not voluntary ahah I use an pre-build base that allows me tu use and compile SCSS files.

  Thanks a lot for your feedback, it is exactly that I need.

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  @DavidMaillard My recommendation on will-change is that only use it when you can't transition thing correctly without it.

  Okay, I'm just curious about the LICENSE though 😅.

  You're welcome!

  0