Preview-Card-Component site using React, CSS-Grid and Flexbox

Community feedback

• 

  Faris P•2,810

  @FarisPalayiPosted over 3 years ago

  Webpage looks good and responds nicely👍

  One suggestion would be to set the image's alt text to empty alt="" since those images are purely decorative and so that assistive technologies can ignore them.

  Marked as helpful

  0
• 

  Bishal Mallick•115

  @bishalmallickPosted over 3 years ago

  bhai aapne to bohot umda quality ka webpage design kia hai... object banake usko render karwane ka idea mast laga... sirf thoda responsive layout me gadbadi ho gaya... doesnt look like the mobile version of the project...

  0

  ---

  

  Gautam•90

  @Gautam1201Posted over 3 years ago

  @bishalmallick Hi, thanks for the feedback! Can you tell me what exactly is wrong with the mobile layout?

  0

  

  Bishal Mallick•115

  @bishalmallickPosted over 3 years ago

  @Gautam1201 tere webpage jab query point hit karta hai tab tera cards ka width viewwidth ko cover karne lagta hai... i mean to say it would be better if you just made the width of the card fixed when the responsive layout hits... you can check my solution for this problem... that way the cards will be of fixed width and height which will look good in the end product...

  0

  

  Gautam•90

  @Gautam1201Posted over 3 years ago

  @bishalmallick Oh ok. It was just a personal preference. Instead of fixing a width to certain pixels, I decided to use min-width and max-width so that it scales up a bit for medium size viewport width. For view width = 375px(as mentioned in the styles guide for mobile layout), it looks exactly as given in the mobile design of the project.

  0