Design comparison
Solution retrospective
I worked with css and html. I'm open for suggestions guys. Cheers
Community feedback
- @NehalSahu8055Posted over 1 year ago
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
➨Remove
margins
from the.textbox
as this will not dynamically center the card-
To properly center the container.
-
USING FLEXBOX
body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
- USING GRID
body{ min-height: 100vh; display: grid; place-items: center; }
➨ Use
Semantics
for the proper design of your code.<body> <header> <nav>...</nav> </header> <main>...</main> <footer>...</footer> wrap up .attribution div inside footer. </body>
-
Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google.
link.
I hope you find this helpful.
Happy coding😄
Marked as helpful1 -
- @sahilataharPosted over 1 year ago
Congratulation for Project completion
Here is some suggestion for your project. I hope it may helpful.
(1). To center your card you can use:
/* using flex */ display: flex; justify-content: center; align-items: center; /* or using grid */ display: grid; place-items: center;
(2). Fix you credit position at bottom.
.attribution { width: 90%; position: absolute; left: 50%; bottom: 0px; font-size: 11px; text-align: center; transform: translateX(-50%); -webkit-transform: translateX(-50%); -moz-transform: translateX(-50%); -ms-transform: translateX(-50%); -o-transform: translateX(-50%); color: var(--white); }
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord