Design comparison
Solution retrospective
I will appreciate your feedback as well as your advices to have a better (shorter ?) code.π
Community feedback
- @EmmanuelHexerPosted over 2 years ago
Great work man, Nicely done
-
One tip i can give you is wrap the whole content with specific tag like
main
and attribution withfooter
tag. -
always Include alt attribute in your
img
elements.
Marked as helpful0 -
- @steezyzaPosted over 2 years ago
This is a good attempt, well done.
The only issues I noticed
a) accessebility: Semantic HTML helps code readers navigate through the page easier e.g.
<header> <main> <footer>
and also includealt
in your image tag e.g.<img src="./assets/images/image-avatar.png" alt="nft-card">
b) the image should have a border radius e.g.
border-radius: 5px;
All the best for future solutions
Marked as helpful0 - @RioCantrePosted over 2 years ago
Hello there! Great work with this one. Regarding the solution you submitted, I think you should also take notes of the followingβ¦
- Wrap the whole content with specific tag like
main
andattribution
withfooter
tag. For HTML structures, refer it with this one Semantics - Include
alt
with description in image tags. Like this line<img src="./assets/images/image-avatar.png">
- Add
border-radius: 10px;
in#equilibrium
rule set. Apply also in the hover state
Above all, The design looks good. Keep it up! Hope this is helpful!
Marked as helpful0 - Wrap the whole content with specific tag like
- Account deleted
Hi there π
Congratulate on finishing your project π. You did a great job π‘
I give some suggestions to help you take your project design to the next level ππ
- Add border-radius to the image also as you used in the card
- You can add some box-shadow to the card too
Happy coding β
Maqsud
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord