Submitted almost 2 years ago

Preview card component with HTML and CSS

Kevin Molina• 200

@KevinMA95

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

Product preview card component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

Any advice is welcome, trying to practice some HTML and CSS before starting the junior challenges :)

Community feedback

バレンタイン 😈• 64,190

@VCarames

Posted almost 2 years ago

Hey @KevinMA95, adding to what was said above/below:

To give you HTML code structure, you want to set up your code in the following manner (only did parent containers):

HTML

   <body>
      <main>
        <article class=“card-container”>
          <picture></picture>
          <div class="card-content">
          </div>
        </article>
      </main>
    </body>

The Main Element identifies the main content of the document.

While the Article Element will serve as the card’s container, because the card represents a complete, or self-contained, section of content that is, in principle, independently reusable.

More info:

https://web.dev/learn/html/headings-and-sections/

The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.
The old price is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.
Your "button" was created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.

Happy Coding! 👻🎃

Marked as helpful

Kevin Molina• 200

@KevinMA95

Posted almost 2 years ago

Hello @vcarames, Thank you so much for the tips and explanations they were really helpful also I didn't notice I was missing the <a> tag in my button, thanks for pointing that out.

Happy coding!

Lucas 👾• 104,420

@correlucas

Posted almost 2 years ago

👾Hello @KevinMA95, Congratulations on completing this challenge!

Your solution its almost done and I’ve some tips to help you to improve it:

The image is getting distorted, to avoid this behavior, use these steps, first add display: block and max-width: 100% to the <img> selector. To improve the responsiveness even more by adding the auto-crop property you can add object-fit: cover to make the image crop inside the container. Here’s the code:

img {
    display: block;
    object-fit: cover;
    max-width: 100%;
}

Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

See the example below:

<picture>
  <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
  <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
</picture>

👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

✌️ I hope this helps you and happy coding!

Marked as helpful

Kevin Molina• 200

@KevinMA95

Posted almost 2 years ago

@correlucas Thank you so much for the tips Lucas, I didn't notice the image was getting distorted also I'll start looking into the <picture> tag for my future projects.

Happy coding!

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord