Design comparison
Community feedback
- Account deleted
Hello Coder👏
Your solution is great✨ and congratulations for successfully completing an another newbie challenge🎉
and there is a small suggestion that might be helpful for you
<h1> tag :
It is mandatory to use a
<h1> tag
in your solution because<h1> tag
is most important aspect inaccessibility
and it helpsscreen reader
to navigate with your page in easy wayAnd
H1 tags
also help Google to understand the structure of a page. So if you're using H1s asGoogle recommends
for your page title or content heading, your H1 is effectively telling Google “here's what my page is about.<Picture> tag :
- Looks like you used a wrong method to switch images
- Instead of that you can use
<picture> tag
<picture> <source media="(min-width: 597px)" srcset="./images/image-product-desktop.jpg "> <source media="(min-width: 0px)" srcset=" ./images/image-product-mobile.jpg"> <img src="./images/image-product-mobile.jpg" alt="Product_image"> </picture>
and also there are a lot aspects where you can improve and I really suggest that you have to take a look of my solution✨
Hope that was helpful ☺️
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord