Design comparison
Solution retrospective
Good afternoon everyone!
I send another card, but I'm having a lot of difficulty in the responsiveness. I'm not able to place one card below the other using media queries, it seems that some commands do not respond and others do. For example: when I change the color of the body it works perfectly, however, when I want to change the width of the ID nothing happens. If anyone can help me I would be very grateful. Thanks!!!
Community feedback
- @VCaramesPosted about 2 years ago
Hey @eliseucaputo, great job on this project!
Some suggestions to improve you code:
- To make your content semantically correct, you want to set up your code in the following manner:
<body> <main> <article> <article>Sedans</article> <article>SUV</article> <article>Luxary</article> </article> </main> </body>You'll notice that I used the <article> element for all the containers, and thats because the <article> element encloses a block of related content that makes sense on its own without the rest of the page (e.g., a single blog post).
Since the entire card itself can stand on its owns as well as each individual card, the <article> element** is the best choice for this.
Source:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/article
- While having interactive content (cards, links, icons, buttons, etc…) can definitely make content less static, if not done properly, it can actually have negative effect on your users experience. By simply just applying a “hover” effect to your content, you’re assuming that every device is compatible with “hover” effects. Unfortunately, most devices are not. To provide your users a better experience, you can use the @media (hover: hover) . Now users that that are devices that are not “hover” compatible will be able to enjoy your content.
Sources:
https://css-tricks.com/solving-sticky-hover-states-with-media-hover-hover/
Happy Coding!
Marked as helpful0@eliseucaputoPosted about 2 years ago@vcarames Thank for your suggestions.
I replaced those tags and I've changed the @media to the end of the code. Therefore, I solved the problem with responsiveness.
0 - @correlucasPosted about 2 years ago
👾Hello @eliseucaputo, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a
single classto manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.✌️ I hope this helps you and happy coding!
0 - @AdrianoEscarabotePosted about 2 years ago
Hi Eliseu Caputo, how are you?
I really liked the result of your project, but I have some tips that I think you will like:
1- Every page should have one main landmark
<main>. So replace the div that wraps the whole content with<main>to improve the accessibility. click here2- All page content should be contained by landmarks, you can understand better by clicking here: click here
We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.
Example:
native HTML5 reference elements:
<body> <header>This is the header</header> <nav>This is the nav</nav> <main>This is the main</main> <footer>This is the footer</footer> </body>ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:
<body> <div role="banner">This is the header</div> <div role="navigation">This is the nav</div> <div role="main">This is the main</div> <div role="contentinfo">This is the footer</div> </body>It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.
Link to read more about: click here
2- Why it Matters
Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.
HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.
Rule Description
It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.
Link to read more about: click here
Prefer to use
removerpxto have your page working better across browsers and resizing the elements properlyThe rest is great!!
Hope it helps...👍
0@eliseucaputoPosted about 2 years ago@AdrianoEscarabote Thank your for your contribuition!
I've solved some problems with the code, including about the semantic. I'll read these articles. One more time, Thank you!
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord