Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Prettier to beautify the code, Gitlens to ease my commit.

@Kareem1470

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I was first disoriented because I thought that I will have to create to the qr-code from scratch, was really relieved when I realized that that wasn't the case.

I will take my time analyzing what I am to create before rushing into it.

Was really happy to finish this challenge with bare minimum help.

What challenges did you encounter, and how did you overcome them?

Had issues with committing, staging, generally github .

Went back to the video links that's located in the 'setting up your development environment' path

What specific areas of your project would you like help with?

The best property to center items using both CSS and HTML?

Is responsive text really adviceable to use?

A better guide on PIXELS [px] ?literally guessed the ones I used for this challenge.

An easy way to use Github for dummies?

Thanks for the feedbacks in advance, your correction will go a long way.

Community feedback

MikDra1 6,320

@MikDra1

Posted

I encourage you to use this technique to make the card responsive with ease:

.card {
width: 90%;
max-width: 600px;
}

On the smaller screens card will be 90% of the parent (here body), but as soon as the card will be 600px it will lock with this size.

Also to put the card in the center I advise you to use this code snippet:

.container {
display: grid;
place-items: center;
}

Hope you found this comment helpful 💗💗💗

Good job and keep going 😁😊😉

Marked as helpful

1

@ezeaniiandrew

Posted

Hi, congratulations on completing this challenge. Here are a couple of things that could improve your solution:

  • The qr-code image is not displaying. I took a quick look at your code and found the culprit:
<img src="images/image-qr-code.png" alt="image-qr-code"/>

Removing the images/ should fix the problem.

  • To style your project in a deterministic way, you need to reset the default styles applied by the browser. You can do that by adding the following resets to your stylesheet:
* {
  padding: 0;
  margin: 0;
  box-sizing: border-box;
  }

You can read more about it here

  • You already have a good understanding on how to align items centrally. The only issue with your code is it's organization. The grid-container element is redundant. Simply remove it from your HTML and move the class to your body element and everything should work fine.
  • Most times, the width value in PX usually comes from the design provided by the designer. But in the absence of a design, we usually guess and tinker with it to see what looks best — just as you've done.
  • Based on the fact that you've successfully pushed your code to GitHub, I believe you already possess some basic knowledge on how it works. To help you further, you'll need to expatiate on the difficulties you're having when using GitHub.
  • You can improve the responsiveness of your solution by reading about CSS min function.

Overall, you've done a good job on this challenge. Keep it up

Marked as helpful

1

@SvitlanaSuslenkova

Posted

<img src="images/image-qr-code.png" alt="image-qr-code"/> But you don't have image folder, maybe removed? Change the path to <img src="./image-qr-code.png" alt="image-qr-code"/>. Hope you found this comment helpful :)

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord