Prduct Preview Card Component using HTML5 and CSS3

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • The product image is not a decoration. You must not use the background-image property to add the product image. Instead, use the <img> and <picture> tag to add the image. Use the background-image property only for decorative images that do not add any information to the page.

  CSS 🎨:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. Source 📘.

  • The width: 100vw property in the .container tag is not necessary. This will create a horizontal scrollbar on some devices.

  • Use min-height: 100vh instead of height: 100vh. The height property can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  0