Practicing more BEM principles^

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hello there, Raymart Pamplona! 👋

  Don't worry, I think you've done a good job on this challenge! 😀 Your solution looks great and I really like that you added a hover state to the options in the box to the left (that's something many submissions of this challenge seem to miss). 😆

  I just think making the background of the attribution the same color as the background of the page (i.e., dark blue instead of white) would make your solution look nicer.

  Also, you can make div.cover a direct child of the body and avoid having an extra container, if you'd like (and that way, the background will fill up the entire area of the screen—even on larger screens). 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  @ApplePieGiraffe Hahaha also I when I see this challenge being submitted, I try to hover fast the icons and expecting something to pop up right. That div.cover oh yes, that is something that I feel bad about since like what you said, I can avoid extra container but the thing is that I don't really like to put up many things in the body tag and that's why I created the container. But still could have been avoid yeah. Thank you for the feedback really appreciated it and Imma refactor it so that the bottom will be colored as well^^

  0
• 

  Akshay Meshram•390

  @akshay63Posted over 3 years ago

  Hey, @Raymart Pamplona! Apart from some minor changes that APG mentioned, your solution is looking great. It's my current challenge and in 1-2 hours I'll submit it. Great work!👍😎

  0

  ---

  

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  @akshay63 Goodluck with the challenge and thank you as well^

  0