practice 9

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @blahking, Congratulations on completing this challenge!

  I like the work you’ve done here, your solution is almost complete. I’ve some suggestion for you to improve the code/design:

  1.Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.

  To save your time you can code you whole page using px and then in the end use a VsCode plugin called px to rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

  2.Use the tag <picture>to wrap the product image inside the html instead of using it as <img> or background-image (with the css). Using <picture> you wrap both images (desktop and mobile) and have more control over it, since you can set in the html when the images changes setting the screen size for each image.ote that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  blahblah•240

  @blahkingPosted about 2 years ago

  Hello@correlucas. Thanks for your suggestions! Very helpful to me. I'll apply it to my next challenges.

  1

  

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  @blahking Hey Blah! I'm happy to hear that, keep posting amazing content =)

  0