practice 11

Community feedback

• 

  omar saleh•150

  @omarsaleh11Posted about 2 years ago

  I have done the same challenge a moment ago, nice job @blahking

  just some changes are needed as the background put the same as the design, and try to put max-width to the paragraphs = 21.5ch.

  I think those will help u enough happy coding

  1

  ---

  

  blahblah•240

  @blahkingPosted about 2 years ago

  Thanks for your comment. Happy coding together!

  0
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello blahblah, Congratulations on completing this challenge!

  Two tips for you:

  1.Use max-width: 100% for the cards in the mobile version to allow the cards grow 100% of the width considering the paddings and avoid to have a lateral gap (limited by a fixed width).

  2.Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  ✌️ I hope this helps you and happy coding!

  0

  ---

  

  blahblah•240

  @blahkingPosted about 2 years ago

  Good evening Lucas~ Thanks for your comment.

  I use width: 90% in the mobile for keeping 10% padding between the cards. Block element's default width is 100% so it's unnecessary to set max-width: 100% I think 👀.

  The cards are wrapped with <article> so I use the <article> tag directly to manage the same content of all cards. I'll keep in mind that using proper class name to control the styles.

  Thanks for your tips again! Happy coding!

  0