Pomodoro Timer created with the Vanilla JS framework

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 2 years ago

  Excellent work on this project, Kevin! It looks great and works well!

  My main piece of feedback would be to avoid adding event listeners to non-interactive elements. For example, you're using li elements to switch timers and an img element to open the settings modal.

  Whenever you expect a user to interact with an element, you should use an interactive element (e.g. a' or button`). This will allow people who can't/don't use a mouse or trackpad to use your app.

  As the timer switchers and the settings trigger don't navigate to new pages, I'd recommend using button elements to trigger the actions.

  It's always a good habit to try navigating anything you build while only using your keyboard to see if you can still use the app. If not, it needs refactoring to make it more accessible.

  I hope this helps. Keep up the great work!

  Marked as helpful

  1

  ---

  

  Kevin Mason•280

  @mrfinesse47Posted over 2 years ago

  @mattstuddert Thanks for that, I will keep it in mind for the next project, and test projects with the keyboard + accessibility developer tools from now on.

  1
• 

  Vincent Yan•210

  @envincebalPosted over 2 years ago

  Very well done! Everything works as it should and the app looks great on all screen sizes. The changes in the settings all work seamlessly. My only suggestion may be a personal preference. But I'd consider making the clock not count down immediately until you click on the clock. To me is just a usability thing. Other than that, great work!

  1

  ---

  

  Kevin Mason•280

  @mrfinesse47Posted over 2 years ago

  @envincebal yes, the first thing I noticed checking out other solutions was a "start" button, i do not know why i didnt think of that lol. It wasnt in the design docs but it is pretty much common sense looking at it now.

  1

  

  Vincent Yan•210

  @envincebalPosted over 2 years ago

  @mrfinesse47 Yeah no worries! We're all here to help each other get better. You're doing great!

  1

  

  Kevin Mason•280

  @mrfinesse47Posted over 2 years ago

  @envincebal ok i got a start button working.

  1

  

  Vincent Yan•210

  @envincebalPosted over 2 years ago

  @mrfinesse47 Awesome! Great work, it works perfectly.

  1