Pomodoro (React, ContextAPI, tailwind, flexbox, CSS Grid, responsive)
Design comparison
Solution retrospective
Not my cleanest but If there's anyway you think I can Improve let me know! Any and all feedback will be much appreciated thank you!
Community feedback
- @daniloparrajrPosted over 1 year ago
Hi David, your solution looks and works very well!
I like how the code is clean and easy to understand! Great job!
Please see my suggestions below
- Use the "button" tag on increment and decrement controls of your pomodoro, short break, and long break number fields.
Doing so will give more accessibility features to your app for example users can tab through those fields and will still be able to increment and decrement just by using their keyboard.
-
Use radion buttons for the Font and Color fields, also for accessibility. e.g. right now you can't select those through tabbing. See my solution as a reference.
-
Use the form tag on the settings modal for accessibility e.g. users are not able to submit their changes by pressing the enter key on their keyboard.
-
Modal accessibility also can be improved e.g. pressing escape key when the modal active should close the modal
Hope this helps, all the best!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord