Pomodoro (React, ContextAPI, tailwind, flexbox, CSS Grid, responsive)

Community feedback

• 

  P

  Danilo Parra Jr•410

  @daniloparrajrPosted over 1 year ago

  Hi David, your solution looks and works very well!

  I like how the code is clean and easy to understand! Great job!

  Please see my suggestions below

  1. Use the "button" tag on increment and decrement controls of your pomodoro, short break, and long break number fields.

  Doing so will give more accessibility features to your app for example users can tab through those fields and will still be able to increment and decrement just by using their keyboard.

  2. Use radion buttons for the Font and Color fields, also for accessibility. e.g. right now you can't select those through tabbing. See my solution as a reference.

  3. Use the form tag on the settings modal for accessibility e.g. users are not able to submit their changes by pressing the enter key on their keyboard.

  4. Modal accessibility also can be improved e.g. pressing escape key when the modal active should close the modal

  Hope this helps, all the best!

  0