pod-request-access-landing-page

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 3 years ago

  The only visual difference I see is the form button is very small but I’d need to inspect in browser to know the problem there.

  Important things to fix in this though

  • always label inputs. Essential
  • error message containers need linking to the input via aria describedby on the input pointing to the error element ID
  • error messages should have an aria live attribute
  • use the button element not input type button
  • alt text cannot be a hashtag. It can be empty for decorative images but these are not decorative, they are valuable content
  • similarly the logo is the most important content on the page. Don’t hide the name of the site/product with empty alt on that
  • remove br from your heading. Limit line length with max width in ch or rem, not with brs.
  • stop nesting your scss! Really really important to stop that habit straight away. It’s wrecking your css specificity. When writing scss you should end up with the exact same css you would have written - single class selectors with specificity nice and flat

  Hope this helps you

  Marked as helpful

  0

  ---

  

  Lorenzo Franco•480

  @LfrancosPosted almost 3 years ago

  @grace-snow Thank you so much for all this information! It really helps me, I'll try to apply all the things that you have mention to improve this project!

  1