Design comparison
Solution retrospective
Hey there!
So much fun with Tailwind CSS and always so perfect, beauty and easy.
Any recommendation is always very appreciated.
have a nice day y'all!
Community feedback
- @vanzasetiaPosted over 1 year ago
Hi, @filecc! š
Does this project use the Font Awesome library?
Use
<button>
withtype="submit"
instead of<input type="submit">
. Submit input is a legacy element."Upload your audio to Pod with a single click..." should not be a
<h2>
. It should be a paragraph element. Why did you think it is a sub-title?Having
<h2 class="hidden">Section title</h2>
is not useful since the.hidden
styling is set todisplay: none
. It removes the element both visually and from accessibility tree.Full accessibility tree in Chrome DevTools
Also, "Section title" is not providing information about what will be the content of the content.
If you want you can have a visually hidden heading. It is only visually hidden but still accessible with assistive technologies such as screen reader.
See visually hidden styling ā How-to: Hide content - The A11Y Project
Then, the text content might be telling that the product is used by the following companies. But, you don't need to add visually hidden heading. It is not a must.
For the form validation, you need to programmatically connect the error message with the associated input element. Also, make it as a live region to make screen readers announce the message as soon as it gets populated with the message.
Learn more ā A Guide To Accessible Form Validation
I hope this helps. Have fun coding! š
Marked as helpful1@fileccPosted over 1 year ago@vanzasetia Hi and thanks you so much.
I addressed the iusses you present me.
- I changed the
<input>
tag in abutton
one; - I changed the
<h2>
with a<p>
tag; - I remove the
<h2>Section Title</h2>
that was here just for the HTML Validator, so I removed the section too.
Thanks for all the amazing advices and for the useful resources!
šš
0 - I changed the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord